Skip to content
Snippets Groups Projects
  1. Oct 10, 2015
  2. Oct 01, 2015
  3. Sep 30, 2015
  4. Sep 27, 2015
  5. Sep 23, 2015
    • Vermaat's avatar
      Show diff for variant protein from non-reference start codon · 3c98a1af
      Vermaat authored
      The alternative variant protein sequence translated from a
      non-reference start codon (created by the variant), was not
      color-diffed as normal variant protein sequences are.
      
      In the process we also rename the `oldprotein` and `newprotein`
      fields in the output object to `oldProtein` and `newProtein` to
      be more consistent with other field names.
      3c98a1af
    • Vermaat's avatar
      Visualise protein change, also with alternative start · 851e71fe
      Vermaat authored
      In the case of an alternative start codon (in the reference CDS),
      protein changes were not visualised. This is fixed and a WALTSTART
      warning is also issued.
      
      Also, if a new non-reference start codon is created by the variant,
      visualise this as such.
      851e71fe
    • Vermaat's avatar
      Translate alternative start to M, also in variant · ae70ddfd
      Vermaat authored
      In case of an alternative start codon, the variant CDS was not
      translated to a protein starting with M. This caused the protein
      description machinery to conclude a variant affecting the start
      codon, hence reporting `p.?`.
      
      We fix this by always translating the start codon to M (except
      when the variant actually affects it).
      
      Example: `NM_024426.4:c.1107A>G` (a synomymous mutation) should
      yield `NM_024426.4(WT1_i001):p.(=)`, not `p.?`. The start codon
      for that protein is `CTG`.
      ae70ddfd
  6. Aug 10, 2015
  7. Aug 04, 2015
  8. Jul 15, 2015
    • Vermaat's avatar
      Uncertain stop codon in protein descriptions (fs and ext) · d2f91690
      Vermaat authored
      When a variant results in a frame shift or extension and we don't
      see a new stop codon in the RNA, the protein description should use
      the notation for an uncertain stop codon, e.g., `p.(Gln730Profs*?)`
      instead of `p.(Gln730Profs*96)` where 96 is just the last codon in
      our transcript [1].
      
      To detect this, we now use `to_stop=False` in our `.translate()`
      calls, since that will explicitely return `*` characters for stop
      codons.
      
      We also slightly fix the coloring of changes in the protein sequence
      where previously changed stop codon characters where not included.
      
      [1] http://www.hgvs.org/mutnomen/FAQ.html#nostop
      d2f91690
  9. Jul 09, 2015
  10. Jul 03, 2015
    • Vermaat's avatar
      Use chardet instead of cchardet · dedad241
      Vermaat authored
      Issue #50 showed a problem in our file encoding detection, caused
      by our cut-off for the confidence as reported by the cchardet [1]
      library:
      
          >>> import cchardet
          >>> s = u'NM_000052.4:c.2407\u20132A>G'
          >>> b = s.encode('WINDOWS-1252')
          >>> cchardet.detect(b)
          {'confidence': 0.5, 'encoding': u'WINDOWS-1252'}
      
      We require a confidence stictly greater than 0.5 and default to
      UTF8 otherwise.
      
      If, however, we try the same thing using the chardet [2] library,
      we get a higher confidence for the same string:
      
          >>> import chardet
          >>> chardet.detect(b)
          {'confidence': 0.73, 'encoding': 'windows-1252'}
      
      So the two obvious ways to solve this are:
      
      1. Lower the confidence threshold.
      2. Use chardet instead of cchardet.
      
      We implement the second solution here, since it also removes a C
      library dependency and we are not worried by performance.
      
      Of course the detected encoding remains a guess which can still
      be wrong!
      
      [1] https://github.com/PyYoshi/cChardet
      [2] https://github.com/chardet/chardet
      
      Fixes #50
      dedad241
  11. May 31, 2015
  12. May 18, 2015
  13. May 01, 2015
  14. Apr 30, 2015
  15. Jan 30, 2015
    • Vermaat's avatar
      Discard incomplete genes in genbank reference files · 73c0862f
      Vermaat authored
      Many genbank reference files contain more than one gene, especially
      slices from an assembly. Some of these genes may be incomplete in
      the reference file (i.e., either start or end exceeds the outer
      coordinates). We cannot really do anything with these genes, so we
      discard them during parsing.
      73c0862f
    • Vermaat's avatar
      Fix broken DMD reference in unit tests · 51d8cc50
      Vermaat authored
      51d8cc50
    • Vermaat's avatar
      Add getGeneLocation webservice method · e06452a1
      Vermaat authored
      Given a gene symbol and optional genome build, this returns the location
      of the gene.
      
      Primary motivation for this is LOVD, where it will be used in combination
      with sliceChromsome as an alternative for sliceChromosomeByGene which only
      works on the fixed Ensembl genome build.
      e06452a1
  16. Nov 24, 2014
  17. Oct 21, 2014
  18. Oct 20, 2014
    • Vermaat's avatar
      8acb0970
    • Vermaat's avatar
      Use unicode strings · 2a4dc3c1
      Vermaat authored
      Don't fix what ain't broken. Unfortunately, string handling in Mutalyzer
      really is broken. So we fix it.
      
      Internally, all strings should be represented by unicode strings as much as
      possible. The main exception are large reference sequence strings. These can
      often better be BioPython sequence objects, since that is how we usually get
      them in the first place.
      
      These changes will hopefully make Mutalyzer more reliable in working with
      incoming data. As a bonus, they're a first (small) step towards Python 3
      compatibility [1].
      
      Our strategy is as follows:
      
      1. We use `from __future__ import unicode_literals` at the top of every file.
      2. All incoming strings are decoded to unicode (if necessary) as soon as
         possible.
      3. Outgoing strings are encoded to UTF8 (if necessary) as late as possible.
      4. BioPython sequence objects can be based on byte strings as well as unicode
         strings.
      5. In the database, everything is UTF8.
      6. We worry about uploaded and downloaded reference files and batch jobs in a
         later commit.
      
      Point 1 will ensure that all string literals in our source code will be
      unicode strings [2].
      
      As for point 4, sometimes this may even change under our eyes (e.g., calling
      `.reverse_complement()` will change it to a byte string). We don't care as
      long as they're BioPython objects, only when we get the sequence out we must
      have it as unicode string. Their contents are always in the ASCII range
      anyway.
      
      Although `Bio.Seq.reverse_complement` works fine on Python byte strings (and
      we used to rely on that), it crashes on a Python unicode string. So we take
      care to only use it on BioPython sequence objects and wrote our own reverse
      complement function for unicode strings (`mutalyzer.util.reverse_complement`).
      
      As for point 5, SQLAlchemy already does a very good job at presenting decoding
      from and encoding to UTF8 for us.
      
      The Spyne documentation has the following to say about their `String` and
      `Unicode` types [3]:
      
      > There are two string types in Spyne: `spyne.model.primitive.Unicode` and
      > `spyne.model.primitive.String` whose native types are `unicode` and `str`
      > respectively.
      >
      > Unlike the Python `str`, the Spyne `String` is not for arbitrary byte
      > streams. You should not use it unless you are absolutely, positively sure
      > that you need to deal with text data with an unknown encoding. In all other
      > cases, you should just use the `Unicode` type. They actually look the same
      > from outside, this distinction is made just to properly deal with the quirks
      > surrounding Python-2's `unicode` type.
      >
      > Remember that you have the `ByteArray` and `File` types at your disposal
      > when you need to deal with arbitrary byte streams.
      >
      > The `String` type will be just an alias for `Unicode` once Spyne gets ported
      > to Python 3. It might even be deprecated and removed in the future, so make
      > sure you are using either `Unicode` or `ByteArray` in your interface
      > definitions.
      
      So let's not ignore that and never use `String` anymore in our webservice
      interface.
      
      For the command line interface it's a bit more complicated, since there seems
      to be no reliable way to get the encoding of command line arguments. We use
      `sys.stdin.encoding` as a best guess.
      
      For us to interpret a sequence of bytes as text, it's key to be aware of their
      encoding. Once decoded, a text string can be safely used without having to
      worry about bytes. Without unicode we're nothing, and nothing will help
      us. Maybe we're lying, then you better not stay. But we could be safer, just
      for one day. Oh-oh-oh-ohh, oh-oh-oh-ohh, just for one day.
      
      [1] https://docs.python.org/2.7/howto/pyporting.html
      [2] http://python-future.org/unicode_literals.html
      [3] http://spyne.io/docs/2.10/manual/03_types.html#strings
      2a4dc3c1
  19. Oct 15, 2014
    • Vermaat's avatar
      Fix several error cases in LOVD2 getGS call · bcef1633
      Vermaat authored
      The `getGS` website view for LOVD2 would report "transcript not found" if
      the genomic reference has multiple transcripts annotated or if the variant
      description raises an error in the variant checker.
      bcef1633
  20. Oct 04, 2014
  21. Sep 26, 2014
  22. Sep 22, 2014
Loading