Skip to content

Example website without IFrame

Martijn Vermaat requested to merge no-iframe into master

Considering some of the hard-to-debug issues we experience related to the IFrame, we switch to a non-iframe development environment.

For now, the non-iframe environment is our primary environment, which should support most of our medium-term goals. The iframe environment is still available, but secondary. We'll revisit its bugs when we start embedding the editor in 3rd party websites.

Run the primary development environment with:

npm run dev

And the IFrame-based environment with:

npm run dev-iframe

Open issues

  • Styling on the default website is off. The editor content fills the entire page height, overlapping the bottom panel.
  • Styling on the IFrame website is a bit off (page is a few pixels higher than viewport). Minor issue for now.
  • Editor styles use Bootstrap less variables (included specifically from variables.less), but these are not the variables from the Bootstrap included by the parent website. Minor issue for now.

Merge request reports

Loading