Skip to content
Snippets Groups Projects
  1. Oct 13, 2015
  2. Oct 10, 2015
  3. Oct 01, 2015
  4. Sep 30, 2015
  5. Sep 27, 2015
  6. Sep 25, 2015
  7. Sep 24, 2015
    • Vermaat's avatar
      Merge pull request #79 from mutalyzer/fix-slice-by-gene-positions · e003d85d
      Vermaat authored
      Fix off-by-one in slicing chromosome by gene name
      e003d85d
    • Vermaat's avatar
      Fix off-by-one in slicing chromosome by gene name · e1c4bb41
      Vermaat authored
      The original code would always add one extra downstream base to
      the slice (for genes on the forward and reverse strand).
      
      Correcting this implies that cached slices will not be used by
      new queries requesting the exact same gene and number of upstream
      and downstream bases, effectively invalidating them.
      
      However, most existing cache entries affected by this bug will be
      on GRCh37/hg19, whereas current slices by gene name will yield
      GRCh38/hg38 slices.
      
      The only cache issue I see is trying to use existing cache
      entries created by slicing by gene name, by re-slicing by
      explicit coordinates instead of gene name. To get the old cache
      entry one would have to add an extra downstream base.
      e1c4bb41
Loading