GitLab

Now using ".bat" file extension if platform is 'Windows'. Discussed with @kaspermarstal

make_registration_scripts now supports '--make-scripts shell' for Unix .sh files, and '--make-scripts batch' for Windows .bat files.

Implementation includes suggestion by Jirka Borovec (@Borda)

Replaced single-quotes by double-quotes for command-line arguments, in make_shell_scripts.

It appears that Windows does not like single-quotes. Discussed with @kaspermarstal

ENH: Added selx::StringConverter. Initial use case: conversion to `bool`

Replaced explicit criterion.second comparison to "True" and "False" by `StringConverter::Convert` calls.

FIX #356: do not pickup files other than .json or .xml

Selx 342 improve brain registrations (thanks @N-Dekker)

Fixed #190 by specifying that SuperElastix should used uses the 64-bit toolset (including 64-bit linker), for Visual C++ Debug. Adds `<PreferredToolArchitecture>x64</PreferredToolArchitecture>` to the generated vcxproj files.

Avoided CMake errors on platforms that don't have CMAKE_CONFIGURATION_TYPES (gcc, clang).

ENH: Fix loading bluebrints when --team-name is specified; STYLE: Use default-member-initializer instead of assigning default values in constructor

STYLE: Simplified BlueprintImpl comparison own vs other parameter values

Simplified BlueprintImpl comparison between "own" and "other" ParameterValueType objects, by using the Standard C++ Library implementation of operator!= for `std::vector<std::string>`.

Blueprint improvements

Removed unused #include's. Used angle brackets (instead of double-quotes) for Boost #include's, for consistency. (Angle brackets seem appropriate for external libraries.)

Fixed MSVC Warning Level 4 warning C4702: unreachable code

Now using `ownProperties` (the result of `this->GetComponent( componentName )`) twice, instead of once, in both `ComposeWith` and `MergeProperties`, for both components and connections.

Ensured that `ownProperties` is not modified when ownValues is retrieved, by calling `std::map::find`, instead of `operator[]`, and using `const`.

Fixed MSVC Warning Level 4 warning C4456: declaration of 'ownProperties' hides previous local declaration

Prefer direct use of Standard C++ functionality, when equally good.

BlueprintImpl fixes + support of relative paths to composable Blueprint file

ENH: Add support for intensity normalization, intesity inversion, and subsampling to ITKv4 SyN and ITKv4 ANTs

Relative paths in the "Include" section of a Blueprint file are now resolved relative to the file path of the composing Blueprint.

Requested by @kaspermarstal issue #348 "Fix composable blueprints".

Simplified `BlueprintImpl::MergeFromFile` implementation, adding `const`

Removed `ComponentOrConnectionTreeType` typedef, which I found quite confusing, as it allowed the parameter of `BlueprintImpl::VectorizeValues` to be specified both with and without an extra `&` (based on C++ reference collapsing rules).

I think we should not use BOOST_FOREACH anymore, as it is basically superseded by C++11 range-based for-loop. However, in `BlueprintImpl::FindIncludes`, could not be replaced by a range-based for-loop, as it used an std::pair of iterators. But in this specific case, an `if` statement will do  :-)

Fixes VS2017 /analyze warning C26477 "Use 'nullptr' rather than 0 or NULL (es.47)", which came from BOOST_FOREACH.

Also simplified the lines of code that convert strings to paths.

Declared three of the five private member functions of BlueprintImpl `static`, as these do not use the `this` pointer.

Declared BlueprintImpl constructor `explicit`, to avoid accidental conversions from LoggerImpl to BlueprintImpl.

Bug found by VS2017 /analyze warning C26444: "Avoid unnamed objects with custom construction and destruction (es.84)".

Code Analysis warning C26489 "Don't dereference a pointer that may be invalid: '...' may have been invalidated at line ... (lifetime.1)" appears too often as a false positive.

As I just reported to Microsoft:
https://developercommunity.visualstudio.com/content/problem/469978/c-code-analysis-false-positives-c26489-on-stdmap.html

Blueprint code cleanup