ENH: extra tests, conflicting interface

Modules/Core/ComponentInterface/include/GDOptimizer4thPartyComponent.h

@@ -12,7 +12,7 @@ namespace elx
   class GDOptimizer4thPartyComponent : 
     public Implements <
     Accepting< MetricValueInterface >,
-    Providing < OptimizerUpdateInterface >
+    Providing < OptimizerUpdateInterface, ConflictinUpdateInterface >
     >
 
   {
@@ -24,6 +24,10 @@ namespace elx
     //virtual int ConnectFrom(const char *, ComponentBase*);
     int Set(MetricValueInterface*);
     int Update();
+
+    //template <class ConflictinUpdateInterface> virtual int Update() { return 5; };
+    // "error" : member function templates cannot be virtual
+    int Update(ConflictinUpdateInterface*) { return 5; };
   };
 
 } //end namespace elx

Modules/Core/ComponentInterface/include/Interfaces.h

@@ -23,6 +23,17 @@ public:
   virtual int Update() = 0;
 };
 
+class ConflictinUpdateInterface {
+public:
+ // "error" : member function templates cannot be virtual
+ // template <class ConflictinUpdateInterface> virtual int Update() = 0;
+  //TODO http://en.cppreference.com/w/cpp/language/member_template
+
+  //TODO solution: http://stackoverflow.com/questions/2004820/inherit-interfaces-which-share-a-method-name
+  //TODO better?: http://stackoverflow.com/questions/18398409/c-inherit-from-multiple-base-classes-with-the-same-virtual-function-name
+  virtual int Update(ConflictinUpdateInterface*) = 0;
+};
+
 // Define the accepting interfaces as templated by the providing interface
 
 template<class InterfaceT>

Testing/Unit/elxComponentInterfaceTest.cxx

@@ -87,7 +87,7 @@ TEST_F( InterfaceTest, ConnectByName )
 
   EXPECT_NO_THROW(IFstatus = optimizer3p->ConnectFrom("MetricDerivativeInterface", metric4p));
   EXPECT_EQ(IFstatus, interfaceStatus::noprovider);
-
+ 
   EXPECT_NO_THROW(IFstatus = optimizer4p->ConnectFrom("MetricDerivativeInterface", metric3p));
   EXPECT_EQ(IFstatus, interfaceStatus::noaccepter);
 
@@ -96,21 +96,44 @@ TEST_F( InterfaceTest, ConnectByName )
 TEST_F(InterfaceTest, ConnectAll)
 {
   int connectionCount = 0;
+  int returnval;
+  OptimizerUpdateInterface* updateIF;
   EXPECT_NO_THROW(connectionCount = optimizer3p->ConnectFrom(metric3p));
   EXPECT_EQ(connectionCount, 2); // both MetricValueInterface and MetricDerivativeInterface are connected
 
+  //optimizer3p should have a OptimizerUpdateInterface
+  updateIF = dynamic_cast<OptimizerUpdateInterface*> (optimizer3p);
+  ASSERT_NE(updateIF, nullptr);
+  EXPECT_NO_THROW(returnval = updateIF->Update()); // Update can only be called if metric and optimizer are connected
+
   EXPECT_NO_THROW(connectionCount = optimizer3p->ConnectFrom(metric4p));
   EXPECT_EQ(connectionCount, 1); // only MetricValueInterface is connected
+  
+  //metric4p does not have MetricDerivativeInterface, so optimizer3p cannot run
+
 
   EXPECT_NO_THROW(connectionCount = optimizer4p->ConnectFrom(metric3p));
   EXPECT_EQ(connectionCount, 1); // only MetricValueInterface is connected
 
+  updateIF = dynamic_cast<OptimizerUpdateInterface*> (optimizer4p);
+  ASSERT_NE(updateIF, nullptr);
+  EXPECT_NO_THROW(returnval = updateIF->Update());
+
   EXPECT_NO_THROW(connectionCount = optimizer4p->ConnectFrom(metric4p));
   EXPECT_EQ(connectionCount, 1); // only MetricValueInterface is connected
 
+  updateIF = dynamic_cast<OptimizerUpdateInterface*> (optimizer4p);
+  ASSERT_NE(updateIF, nullptr);
+  EXPECT_NO_THROW(returnval = updateIF->Update());
 
   EXPECT_NO_THROW(connectionCount = metric4p->ConnectFrom(optimizer4p));
   EXPECT_EQ(connectionCount, 0); // cannot connect in this direction
+
+  ConflictinUpdateInterface* update2IF = dynamic_cast<ConflictinUpdateInterface*> (optimizer4p);
+  ASSERT_NE(update2IF, nullptr);
+  EXPECT_NO_THROW(returnval = update2IF->Update(update2IF));
+  
+
 }
 
 } // namespace elx