From 9e6a44e1394cb9508732ceb7f8f8779f63412327 Mon Sep 17 00:00:00 2001 From: Peter van 't Hof <p.j.van_t_hof@lumc.nl> Date: Fri, 6 May 2016 16:43:59 +0200 Subject: [PATCH] No private mutable --- .../nl/lumc/sasc/biopet/core/WriteDependencies.scala | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/biopet-core/src/main/scala/nl/lumc/sasc/biopet/core/WriteDependencies.scala b/biopet-core/src/main/scala/nl/lumc/sasc/biopet/core/WriteDependencies.scala index a43cb3890..529e6830d 100644 --- a/biopet-core/src/main/scala/nl/lumc/sasc/biopet/core/WriteDependencies.scala +++ b/biopet-core/src/main/scala/nl/lumc/sasc/biopet/core/WriteDependencies.scala @@ -30,18 +30,16 @@ import scala.collection.mutable.ListBuffer */ object WriteDependencies extends Logging with Configurable { val root: Configurable = null - private val functionNames: mutable.Map[QFunction, String] = mutable.Map() - - private def createFunctionNames(functions: Seq[QFunction]): Unit = { + private def createFunctionNames(functions: Seq[QFunction]): Map[QFunction, String] = { val cache: mutable.Map[String, Int] = mutable.Map() - for (function <- functions) { + (for (function <- functions) yield { val baseName = function match { case f: Configurable => f.configNamespace case f => f.getClass.getSimpleName } cache += baseName -> (cache.getOrElse(baseName, 0) + 1) - functionNames += function -> s"$baseName-${cache(baseName)}" - } + function -> s"$baseName-${cache(baseName)}" + }).toMap } /** @@ -55,7 +53,7 @@ object WriteDependencies extends Logging with Configurable { val errorOnMissingInput: Boolean = config("error_on_missing_input", false) - createFunctionNames(functions) + val functionNames = createFunctionNames(functions) case class QueueFile(file: File) { private val inputJobs: ListBuffer[QFunction] = ListBuffer() -- GitLab