GitLab

Fix FLOAT UNSIGNED columns

They were caused by the recent code which was trying to decide on
whether or not to show the donation dialog. Its settings aren't set or
accessible during the Travis CLI test and the LOVD installation process.

MySQL 8 is now deprecating FLOAT UNSIGNED, together with DOUBLE UNSIGNED
and DECIMAL UNSIGNED. We have several FLOAT UNSIGNED columns in the
custom column definition array. Remove the UNSIGNED attribute and
updated the inc-upgrade.php script to remove this attribute in the
column definitions in the column table.

We don't need to actually alter the table; that's an expensive action
while not having much benefit - when the feature will be dropped, likely
MySQL will simply ignore the UNSIGNED flag.

MySQL 8 is now deprecating FLOAT UNSIGNED, together with DOUBLE UNSIGNED
and DECIMAL UNSIGNED. We only have one FLOAT UNSIGNED in the fixed table
structure, remove the UNSIGNED attribute.

We don't need to actually alter the table; that's an expensive action
while not having much benefit - when the feature will be dropped, likely
MySQL will simply ignore the UNSIGNED flag.

Release 3.0-26.

Also fixed some indentation in import.php.

Added note to function list; we still have lots of 5.3 users even
though I'd like to go up to 5.4.0.

Fix #495.

Numeric columns were checked based on their perceived length. That's not
correct for various columns such as TINYINT(3) UNSIGNED columns, not
limited to 999 but instead to 255. lovd_getColumnMinMax() generates
correct minimum and maximum values for numeric columns, including the
DECIMAL type column. FLOATs don't have practical minimum or maximum
values that we'll run into, so these are not checked apart from their
data type.

Numeric columns are currently only checked for their format and the
length of the text value inside the field. The length is currently
checked just from the definition of the field. However, a TINYINT(3)
UNSIGNED doesn't allow for 999, even though the (3) suggests that it
does. This new function, lovd_getColumnMinMax() will calculate the
minimum and maximum values of a column and return these, so that values
can properly be checked.

MySQL 8.0.22 and probably others don't describe unsigned integer fields
well when three is no zerofill. Strangely enough, their given length is
deleted from their column definition. This confused
lovd_getColumnLength() completely, and the returned length of the field
was 0. This broke a lot of forms in LOVD. This fix makes sure LOVD will
handle these kind of column definitions from now on.

Closes #495.

Added a donation request dialog

- Introducing the lovd_settings cookie for this. This can later contain settings that don't require a user account.

- Version bump to 3.0-25e.

Fixed hard-coded table name

Replaced hard-coded table name with the proper constant that takes the configured table prefix into account.
- Closes 497.

Fixed various small issues.

- Google.com is blocked. Rechaptcha.net is not.

Fixed error messages and notice when providing an incorrect user level when creating/editing a user.

- Version bump to 3.0-25d.

Fixed LOVD light

- This view is currently not linked to from LOVD+, unless public variants are present, but it's always reachable.

- Don't define in multiple places that VOT columns aren't shared for LOVD+ and LOVD light.
- Also, LOVD+'s method of removing columns for all when turning off the public flag, should not be introduced in LOVD light.